Repository navigation
Conversation
Owner
dagezi11
pushed a commit
to dagezi11/pycdc
that referenced
this pull request
Nov 18, 2026
Merges the 26 targeted decompiler fixes from @EiNSTeiN- (3.11-3.14 bytecode families) on top of main. Three textual conflicts were resolved by keeping both sides: PR ejfkdev#6 stacks on ejfkdev#5, all PRs append tests at the same point in tests/integration.rs, and ejfkdev#4/ejfkdev#5/ejfkdev#6/ejfkdev#24 append test-module declarations at the end of decompiler.rs. Verification with the standard release profile: - real-world corpus 6411/6411 recompile (was 6408/6411) - stdlib corpus 528/528 semantic pass (520 + 8 new padded fixtures) - behavior matrix: all cases pass on 3.9-3.14 (56 failures remain on 3.15, all pre-existing; main had 61 there) - cargo test: 37 integration + 8 + 27 unit tests pass README/CHANGELOG/LIMITATIONS updated (100% real-world, AST-equal 2493).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to keep independent loop rejection guards from moving a return outside the assignment it depends on. The code below currently decompiles incorrectly:
For Python 3.14, pycdc currently emits:
The return now runs for rejected rows, where
coordinatorhas not been assigned. The generic success-suite reconstruction closes at the later independent rejection guard and ejects the dependent return. This change reconstructs the first rejection asif ...: continue, keeping the lookup and return on the accepted path.The same pattern occurs in dictionary lookups:
The recognizer proves the exact fallthrough back edge, assignment, None test and return of that same local. It applies only outside inline comprehensions and only to functions with no exception-table entries. Other shapes retain their existing reconstruction.
The comparison remains
not (value.rating < 10): replacing it withvalue.rating >= 10changes NaN behavior and dispatches to a different user-defined comparison method. Only proved None identity comparisons may invert their identity operator. A leadingif row is None: continueis also supported, and the retrieved value is tested by identity, preserving valid false-valued results such as0andFalse.This reconstruction applies to Python 3.12+, where the compiler uses the
POP_JUMP_IF_NONE/POP_JUMP_IF_NOT_NONElayout matched here. Python 3.11's direction-specific None jumps remain on the existing path.